Add ruby-rbs-sys Rust crate with FFI bindings for RBS parser#47
Closed
alexcrocha wants to merge 1 commit intomasterfrom
Closed
Add ruby-rbs-sys Rust crate with FFI bindings for RBS parser#47alexcrocha wants to merge 1 commit intomasterfrom
alexcrocha wants to merge 1 commit intomasterfrom
Conversation
Author
|
^ Looks like Rust CI is working as intended 👀 |
alexcrocha
force-pushed
the
ar-rust
branch
3 times, most recently
from
825c965 to
223d780
Compare
alexcrocha
requested review from
ChallaHalla,
Morriar,
amomchilov,
jesse-shopify and
vinistock
alexcrocha
commented
Jul 25, 2025
vinistock
reviewed
Jul 28, 2025
vinistock
reviewed
Jul 29, 2025
Morriar
reviewed
Aug 5, 2025
rust/ruby-rbs-sys/build.rs
Outdated
| fn source_files<P: AsRef<Path>>(root_dir: P) -> Vec<String> { | ||
| let mut files = Vec::new(); | ||
|
|
||
| for entry in fs::read_dir(root_dir.as_ref()).unwrap() { |
There was a problem hiding this comment.
Suggested change
| for entry in fs::read_dir(root_dir.as_ref()).unwrap() { | |
| for entry in fs::read_dir(root_dir.as_ref()).map_err(|e| format!("Failed to read source directory: {}", e))? { |
Member
There was a problem hiding this comment.
Similarly here, if you map the error into a string, what happens with the for loop?
rust/ruby-rbs-sys/build.rs
Outdated
| let path = entry.path(); | ||
|
|
||
| if path.is_file() { | ||
| let path = path.to_str().unwrap().to_string(); |
There was a problem hiding this comment.
Suggested change
| let path = path.to_str().unwrap().to_string(); | |
| let path = path.to_str() | |
| .ok_or_else(|| format!("Invalid UTF-8 in filename: {:?}", path))? | |
| .to_string(); |
Member
There was a problem hiding this comment.
I think this too would put a string in a place where we expect a file path.
alexcrocha
force-pushed
the
ar-rust
branch
2 times, most recently
from
f7071bc to
4f43565
Compare
vinistock
reviewed
Aug 18, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
LGTM at this point. With the addition of the second crate, we may discover the need for a few adjustments, but it seems ready
Comment on lines
+5
to
+6
| branches: | ||
| - master |
Member
There was a problem hiding this comment.
Is the branches part necessary? We want this to run on any commit that matches the given paths, so maybe we can remove this?
Closed
alexcrocha
force-pushed
the
ar-rust
branch
2 times, most recently
from
7ac55a5 to
4de62ba
Compare
|
@alexcrocha This PR looks fine to me. I think rebasing on top of the latest trunk would fix the test failure. |
This establishes the foundation for using RBS functionality from Rust. - Generated FFI bindings via bindgen from RBS C headers - Set up build configuration to link with the RBS library - Added initial tests for basic functionality (constant pool, parser) - Configured workspace structure in rust/Cargo.toml The -sys crate follows Rust conventions for FFI bindings, keeping raw unsafe bindings separate from future safe API wrappers. Future commits will add a separate safe wrapper crate on top of these bindings.
Author
|
This work has been upstreamed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -sys crate follows Rust conventions for FFI bindings, keeping raw unsafe bindings separate from future safe API wrappers.
Future commits will add a separate safe wrapper crate on top of these bindings.